-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create endpoint for retrieval of all assessment submissions #1210
Create endpoint for retrieval of all assessment submissions #1210
Conversation
9f7b6f3
to
4b03ad8
Compare
2f67e42
to
b4ff325
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
conn, | ||
%{ | ||
"group" => "false", | ||
"pageSize" => "100000000000", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha sure, maybe in the future we can filter by assessment name (it's a use case for the PA because we export the grades to Canvas separately).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes, that would be a good future change to generalize the export function!
priv/repo/seeds.exs
Outdated
@@ -26,7 +26,7 @@ alias Cadet.Accounts.{ | |||
# Cadet.Repo.insert!(%Cadet.Settings.Sublanguage{chapter: 1, variant: "default"}) | |||
|
|||
if Cadet.Env.env() == :dev do | |||
number_of_students = 100_000 | |||
number_of_students = 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason this is reduced again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was taking too long to reset the db :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oof 😢 ok maybe we will see how then, we can change it back later haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though I think we can put it to 1000 to mimic 1101S?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, 1000 would be good! doesnt take too long for a one time set up (at most a minute).
Frontend PR: source-academy/frontend#3076
Branched from #1180
Creates an endpoint that obtains all assessments submitted without any filter or pagination. Admin-only endpoint.