Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.0 with Hosting on GitHub Pages #215

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

saad-bhatti
Copy link

Version 3.0 Pull Request

This pull request introduces several improvements and features to the project. The changes are aimed at improving the code structure, maintainability, and overall functionality. Below is a summary of the updates included in this version:

General Refactor

  • Created a pages directory to better organize components.
  • Renamed components to reflect their purpose clearly.
  • Separated styles.css into individual CSS files for each component or page.
  • Replaced hardcoded attributes with arrays and attribute mapping.
  • Formatted the code for consistency.

Code Climate Integration

  • Removed duplicate warnings flagged by Code Climate.
  • Formatted code using Prettier for improved readability.

GitHub Actions

  • Integrated Code Climate into the GitHub Actions workflow for automatic test coverage reporting.
  • Configured Jest to generate coverage reports in lcov format and upload coverage data after each test run.
  • Addressed Babel warnings by adding @babel/plugin-proposal-private-property-in-object.
  • Resolved issues with open handles and dependencies.

GitHub Pages Changes

  • Created a 404.html file to handle routing issues on GitHub Pages.
  • Added a script in index.html to fix single-page application routing problems.

Unit Tests

  • Added unit tests for all components, pages, and App.js to ensure code reliability.

Contact Page

  • Added a frontend-based contact page using EmailJS to allow users to send emails to the portfolio owner.
  • Provided additional access points for the owner's social media links.
  • Included unit tests for contact-related components.

Documentation

  • Improved the project's README file with more detailed setup instructions.
  • Added documentation on the project’s file structure and customization options.

These changes significantly enhance the maintainability and functionality of the project, ensuring a better experience for both developers and users.

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
soumyajit-pdig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 1, 2024 10:42pm

@saad-bhatti
Copy link
Author

saad-bhatti commented Oct 1, 2024

Here is a preview of the portfolio hosted on GitHub Pages.
And here is the repository where the changes were made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant