Add support for decoding event streams #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 19, 2023
Codecov Report
@@ Coverage Diff @@
## 7.x.x #566 +/- ##
==========================================
- Coverage 78.87% 78.72% -0.16%
==========================================
Files 71 73 +2
Lines 6292 6487 +195
==========================================
+ Hits 4963 5107 +144
- Misses 1329 1380 +51
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
0xTim
approved these changes
Jul 20, 2023
| public struct EventDecodingContainer { | ||
| let payload: ByteBuffer | ||
|
|
||
| public func decodePayload() -> ByteBuffer { |
There was a problem hiding this comment.
Minor nit - this has no DocC comments
Comment on lines
22
to
24
| public init() {} | ||
|
|
||
| public func decode<T: Decodable>(_ type: T.Type, from buffer: inout ByteBuffer) throws -> T { |
There was a problem hiding this comment.
Do these need to be public if the type isn't?
adam-fowler
added a commit
that referenced
this pull request
Jul 24, 2023
* Add EventStream type * Split event stream code into two files * If response is chunked assume it is raw * Fix test errors * Fix a couple strict concurrency issues I missed * Add tests for EventStreams * Changes from PR review
adam-fowler
added a commit
that referenced
this pull request
Jul 29, 2023
* Add EventStream type * Split event stream code into two files * If response is chunked assume it is raw * Fix test errors * Fix a couple strict concurrency issues I missed * Add tests for EventStreams * Changes from PR review
adam-fowler
added a commit
that referenced
this pull request
Aug 12, 2023
* Add EventStream type * Split event stream code into two files * If response is chunked assume it is raw * Fix test errors * Fix a couple strict concurrency issues I missed * Add tests for EventStreams * Changes from PR review
adam-fowler
added a commit
that referenced
this pull request
Dec 24, 2023
* Add EventStream type * Split event stream code into two files * If response is chunked assume it is raw * Fix test errors * Fix a couple strict concurrency issues I missed * Add tests for EventStreams * Changes from PR review
adam-fowler
added a commit
that referenced
this pull request
Apr 5, 2024
* Add EventStream type * Split event stream code into two files * If response is chunked assume it is raw * Fix test errors * Fix a couple strict concurrency issues I missed * Add tests for EventStreams * Changes from PR review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See S3.SelectObjectContent, Lambda.InvokeWithResponseStream etc. You can see documentation on decoding these here https://docs.aws.amazon.com/AmazonS3/latest/API/RESTSelectObjectAppendix.html.
AWSEventStreamtype that reads from a base ByteBuffer async sequence.Related PRs: soto-project/soto-codegenerator#74, soto-project/soto#686