Remove AWSClient EventLoop APIs #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adam-fowler
commented
Jun 18, 2023
•
adam-fowler
commented
- AWSClient.execute functions
- AWSClient.getCredential
- AWSClient.signURL/signHeaders
- Fix up waiter, paginate, service and STSAssume code reliant on EventLoop based AWSClient.execute
- Merge AWSClient, AWSService and AWSClient+Waiter files with async files
Codecov Report
@@ Coverage Diff @@
## 7.x.x #553 +/- ##
==========================================
+ Coverage 76.37% 77.49% +1.12%
==========================================
Files 79 76 -3
Lines 8190 7927 -263
==========================================
- Hits 6255 6143 -112
+ Misses 1935 1784 -151
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
0xTim
requested changes
Jun 18, 2023
0xTim
approved these changes
Jun 19, 2023
0xTim
reviewed
Jun 19, 2023
| @@ -101,13 +101,11 @@ extension AWSClient { | |||
| /// - maxWaitTime: Maximum amount of time to wait | |||
| /// - logger: Logger used to provide output | |||
| /// - eventLoop: EventLoop to run API calls on | |||
There was a problem hiding this comment.
The event loop is mentioned in the docs here but no longer used
0xTim
reviewed
Jun 19, 2023
Co-authored-by: Tim Condon <[email protected]>
adam-fowler
added a commit
that referenced
this pull request
Jul 5, 2023
* Remove AWSClient.execute calls with EventLoop * Fix STSAssumeRole after removing EventLoop execute * Fix AWSClient waiter code * Remove commented out code * Remove EL credential functions * Merge async files with parent implementations * Delete AWSClient+Waiter+async.swift * Fix up paginate code * Remove EventLoop from execute closure * Changes requested in PR * Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift Co-authored-by: Tim Condon <[email protected]> --------- Co-authored-by: Tim Condon <[email protected]>
adam-fowler
added a commit
that referenced
this pull request
Jul 5, 2023
* Remove AWSClient.execute calls with EventLoop * Fix STSAssumeRole after removing EventLoop execute * Fix AWSClient waiter code * Remove commented out code * Remove EL credential functions * Merge async files with parent implementations * Delete AWSClient+Waiter+async.swift * Fix up paginate code * Remove EventLoop from execute closure * Changes requested in PR * Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift Co-authored-by: Tim Condon <[email protected]> --------- Co-authored-by: Tim Condon <[email protected]>
adam-fowler
added a commit
that referenced
this pull request
Jul 5, 2023
* Remove AWSClient.execute calls with EventLoop * Fix STSAssumeRole after removing EventLoop execute * Fix AWSClient waiter code * Remove commented out code * Remove EL credential functions * Merge async files with parent implementations * Delete AWSClient+Waiter+async.swift * Fix up paginate code * Remove EventLoop from execute closure * Changes requested in PR * Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift Co-authored-by: Tim Condon <[email protected]> --------- Co-authored-by: Tim Condon <[email protected]>
adam-fowler
added a commit
that referenced
this pull request
Jul 5, 2023
* Remove AWSClient.execute calls with EventLoop * Fix STSAssumeRole after removing EventLoop execute * Fix AWSClient waiter code * Remove commented out code * Remove EL credential functions * Merge async files with parent implementations * Delete AWSClient+Waiter+async.swift * Fix up paginate code * Remove EventLoop from execute closure * Changes requested in PR * Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift Co-authored-by: Tim Condon <[email protected]> --------- Co-authored-by: Tim Condon <[email protected]>
adam-fowler
added a commit
that referenced
this pull request
Jul 24, 2023
* Remove AWSClient.execute calls with EventLoop * Fix STSAssumeRole after removing EventLoop execute * Fix AWSClient waiter code * Remove commented out code * Remove EL credential functions * Merge async files with parent implementations * Delete AWSClient+Waiter+async.swift * Fix up paginate code * Remove EventLoop from execute closure * Changes requested in PR * Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift Co-authored-by: Tim Condon <[email protected]> --------- Co-authored-by: Tim Condon <[email protected]>
adam-fowler
added a commit
that referenced
this pull request
Jul 29, 2023
* Remove AWSClient.execute calls with EventLoop * Fix STSAssumeRole after removing EventLoop execute * Fix AWSClient waiter code * Remove commented out code * Remove EL credential functions * Merge async files with parent implementations * Delete AWSClient+Waiter+async.swift * Fix up paginate code * Remove EventLoop from execute closure * Changes requested in PR * Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift Co-authored-by: Tim Condon <[email protected]> --------- Co-authored-by: Tim Condon <[email protected]>
adam-fowler
added a commit
that referenced
this pull request
Aug 12, 2023
* Remove AWSClient.execute calls with EventLoop * Fix STSAssumeRole after removing EventLoop execute * Fix AWSClient waiter code * Remove commented out code * Remove EL credential functions * Merge async files with parent implementations * Delete AWSClient+Waiter+async.swift * Fix up paginate code * Remove EventLoop from execute closure * Changes requested in PR * Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift Co-authored-by: Tim Condon <[email protected]> --------- Co-authored-by: Tim Condon <[email protected]>
adam-fowler
added a commit
that referenced
this pull request
Dec 24, 2023
* Remove AWSClient.execute calls with EventLoop * Fix STSAssumeRole after removing EventLoop execute * Fix AWSClient waiter code * Remove commented out code * Remove EL credential functions * Merge async files with parent implementations * Delete AWSClient+Waiter+async.swift * Fix up paginate code * Remove EventLoop from execute closure * Changes requested in PR * Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift Co-authored-by: Tim Condon <[email protected]> --------- Co-authored-by: Tim Condon <[email protected]>
adam-fowler
added a commit
that referenced
this pull request
Apr 5, 2024
* Remove AWSClient.execute calls with EventLoop * Fix STSAssumeRole after removing EventLoop execute * Fix AWSClient waiter code * Remove commented out code * Remove EL credential functions * Merge async files with parent implementations * Delete AWSClient+Waiter+async.swift * Fix up paginate code * Remove EventLoop from execute closure * Changes requested in PR * Update Sources/SotoCore/Waiters/AWSClient+Waiter.swift Co-authored-by: Tim Condon <[email protected]> --------- Co-authored-by: Tim Condon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.