Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use latest af-webpack with terser support #844

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jrschumacher
Copy link

No description provided.

@jrschumacher
Copy link
Author

@sorrycc any chance you could get this in?

@jrschumacher
Copy link
Author

@ikobe ^

@jrschumacher
Copy link
Author

@sorrycc
我们能得到这个吗?

@sitch
Copy link

sitch commented Mar 15, 2019

bump

@zjjjjjjjjjjd
Copy link

hey,can this commit solve my problem?

Failed to minify the bundle. Error: index.js from UglifyJs
Unexpected token: name (root) [index.js:72442,4]
    at doneHandler (D:\git\test\nw\template-dva\node_modules\af-webpack\lib\build.js:91:27)
    at emitRecords.err (D:\git\test\nw\template-dva\node_modules\webpack\lib\Compiler.js:265:13)
    at Compiler.emitRecords (D:\git\test\nw\template-dva\node_modules\webpack\lib\Compiler.js:371:38)
    at emitAssets.err (D:\git\test\nw\template-dva\node_modules\webpack\lib\Compiler.js:258:10)
    at applyPluginsAsyncSeries1.err (D:\git\test\nw\template-dva\node_modules\webpack\lib\Compiler.js:364:12)
    at next (D:\git\test\nw\template-dva\node_modules\tapable\lib\Tapable.js:218:11)
    at Compiler.compiler.plugin (D:\git\test\nw\template-dva\node_modules\webpack\lib\performance\SizeLimitsPlugin.js:99:4)
    at next (D:\git\test\nw\template-dva\node_modules\tapable\lib\Tapable.js:220:14)
    at callback (D:\git\test\nw\template-dva\node_modules\copy-webpack-plugin\dist\index.js:126:17)
    at Compiler.afterEmit (D:\git\test\nw\template-dva\node_modules\copy-webpack-plugin\dist\index.js:220:13)
    at Compiler.applyPluginsAsyncSeries1 (D:\git\test\nw\template-dva\node_modules\tapable\lib\Tapable.js:222:13)    at Compiler.afterEmit (D:\git\test\nw\template-dva\node_modules\webpack\lib\Compiler.js:361:9)
    at require.forEach.err (D:\git\test\nw\template-dva\node_modules\webpack\lib\Compiler.js:350:15)
    at D:\git\test\nw\template-dva\node_modules\async\dist\async.js:473:16
    at iteratorCallback (D:\git\test\nw\template-dva\node_modules\async\dist\async.js:1064:13)
    at D:\git\test\nw\template-dva\node_modules\async\dist\async.js:969:16
Read more here: http://bit.ly/2tRViJ9

[graceful-process#1404] exit with code:1

@jrschumacher
Copy link
Author

@zjjjjjjjjjjd possible. Another solution is to tell roadhog not to minify and then run your minification via a npm script using terser (which is what I'm doing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants