make creation of git aliases optional

[kljohann]

As I do not use the git aliases provided by the git module but do not want to miss out on the defined functions I propose aliases to be optional (on by default). Is :prezto:module:git → aliases okay?

[ColinHebert]

This isn't a bad idea, it works the same way color or case-sensitive does.

If this change is accepted, every module should have this option and zstyle ':prezto:*:*' alias 'yes' should be set in the .zpreztorc

[sorin-ionescu]

Why don't you use the Git aliases? They are awesome. I'm worried about adding too many zstyles.

[kljohann]

I guess for me there are just to many aliases with names that are too similar so a typo could have annoying consequences. Also I already have aliases in ~/.gitconfig for stuff I use most of the time.

[sorin-ionescu]

So, you have not even tried to use them and just dismissed them.

I have been using them, and typo problems are minimal; they rarely occur.

They are similar for consistency. You just have to memorise the middle letter.

[nibblebot]

aw man. what a terrible reason to reject this :(
lots of people use git's builtin alias ability to not conflict with the global shell aliases.
polluting the alias space with ~100 aliases is a little aggressive as a default option if you just want git prompt functions, much less having no easy way to turn it off :(

[sorin-ionescu]

One man's pollution is another man's treasure.

They are superior to gitconfig aliases.

Had you tried to use them, I might have been more accommodating, but you dismissed them outright.

[escobera]

Having a way to disable the aliases creation will not remove the value from it. I use and like them, but I can see where some other ppl can disagree with the naming convention or even not wanting that many aliases and, for those, a way to disable the aliases creation would be the real treasure.

[bwiggs]

+1

@sorin-ionescu Even if they're great, they're getting in the way of what I'm comfortable with. I might learn to like them, but they're constantly being interpreted as misspellings or conflicting with tools im already using, ex: grc. It'd be nice to be able to turn them off, and then turn them back on later.

[rizzatti]

@bawigga you can check pull #341 too

[varemenos]

Well, back to oh-my-zsh I guess

[sorin-ionescu]

What do you mean? Modify Prezto as you see fit. OMZ also has Git aliases.

On Jan 7, 2014, at 14:29, "Adonis K." [email protected] wrote:

Well, back to oh-my-zsh I guess

—
Reply to this email directly or view it on GitHub.

[jeffcox]

Isn't the whole point of a project like Prezto to maintain your own fork?

[nasenatmer]

I like those aliases too, though I'm constantly grepping ~/.zprezto/modules/git/alias.zsh on what each of them is doing, but a zstyle to let the user decide whether they like them or not doesn't sound like too much complication to me. Hence, 👍 and dito @escobera

[mfussenegger]

could the modules be split in order to avoid the zstyle? git-aliases/ git-functions?

[sorin-ionescu]

No, the point of a module is to be self contained.

[pushrax]

@sorin-ionescu is there a particularly compelling reason not to have this?

[sorin-ionescu]

No.