Add skwp theme

[skwp]

Based on steeef theme, using always-updated vcs_info
and an RVM indicator on the right.

[sorin-ionescu]

Why not edit the steeef theme instead of duplicating it?

PS: If you use a branch instead of master, you can force push when you screw up a pull request, and it will be updated. You don't have to create a new one.

[skwp]

Well I thought the steeef theme might be used by someone, so I didn't want to just screw with it. If no one is using it, why is it included in the distro :) Are these just examples?

thanks for the info on the pull request, didn't know

[skwp]

ps I don't know if you plan on including other people's themes in the distro like robby was doing..so I opened this pull request, but if you don't want it in there, no problem. I know robby seems to have gotten completely overloaded with pulling people's themes in to the point where he stopped doing it entirely

[sorin-ionescu]

I do want to include other people's themes but not like Robby. Themes have to be voted for inclusion by the community. There have been a few theme submissions, but since no one voted for them, they were not merged in. You should add a screenshot like those themes.

[skwp]

Screenshot added to description

[sorin-ionescu]

Ok; so, it's different than steeef's.

[skwp]

Yeah it's definitely different, I just used steeef as a jumping off point - I liked his colors and reused a bunch of the code

[ColinHebert]

Regarding rvm_info_for_prompt and virtualenv_info, wouldn't it be possible to have a variable set in the ruby module to take care of that?

Could you add a link to the screenshot in the theme description?

[sorin-ionescu]

An rvm-info could be added to the ruby module, but it's not necessary since rvm-prompt should be in $PATH and output nothing by default. virtualenv is Python-related.

[ColinHebert]

@sorin-ionescu, damn I mixed everything... I was thinking about rbenv not virtualenv

[sorin-ionescu]

That too should have something similar. There should not be a need for wrappers, other than consistency.

On Apr 23, 2012, at 16:50, Colin [email protected] wrote:

@sorin-ionescu, damn I mixed everything... I was thinking about rbenv not virtualenv

---

Reply to this email directly or view it on GitHub:
https://github.com/sorin-ionescu/oh-my-zsh/pull/156#issuecomment-5291449

[sorin-ionescu]

Is your theme affected by #230?

[skwp]

My stuff works but I'm also using yadr which has its own 'gco' implemented as a simple alias, so maybe it doesn't have the same bug. I'll take a look at the fix on #230...

[skwp]

Yeah my theme doesn't suffer from this bug because I think I had discovered it earlier and entirely nuked the logic about doing the vcs update check. I just do it every time.

[sorin-ionescu]

I think I will get rid of that theme.

I will reopen your theme, and perhaps others, for voting for inclusion once the rebranding is complete. There are more users now.

[sorin-ionescu]

This function does not belong here; it belongs in the Ruby module and not in this form. It will have to be modified to be customisable via zstyles.

[sorin-ionescu]

I would like to reopen this but @github won't let me, and I do not know why.

[sorin-ionescu]

Don't resubmit though.

[sorin-ionescu]

I suspect that if you force push based on a newer parent, it will let me reopen it.

[sorin-ionescu]

I have been playing with your prompt. Displaying the full path can be a problem.

[skwp]

I prefer to know exactly where I am. In rails apps you always have the same paths in different apps so you can't just show the last part of the path...

[sorin-ionescu]

I am not sure why, but GitHub won't let me reopen this issue. There is no reopen button.