Risky switch-to-command-mode vi binding

[huyl]

I gotta say I laughed when I saw this in the editor module:

# Switch to command mode.
bindkey -M viins "jk" vi-cmd-mode
bindkey -M viins "kj" vi-cmd-mode

Cute, but doesn't belong in a useful project like this one. Can you really say that users won't ever intend to type "jk" at the command line? For example, a filename could contain these characters. We probably shouldn't surprise users like that.

[huyl]

Oh wow, it's worse than I thought. Because of these bindings, when you type 'j' or 'k', the ZLE pauses momentarily and the character doesn't appear immediately -- to see if you'll type the second character.

That's very silly

[sorin-ionescu]

Neither jk nor kj are often found in English. So, having them does not cause a lot of problems. It doesn't not seem to pause on my end.

[sorin-ionescu]

I'm open to removing them if there are votes to do so.

[hierynomus]

+1 Pauses slightly indeed. Characters appear immediately if you directly type another letter after the j or k.

[hierynomus]

Just ran into this the hard way, we have a guy whose git alias is dijkstra, and I cannot get to his repositories because the I get "dtra"...
First "di", then "jk" (end up in command mode), "s" substitute (insert mode again) "tra"...

Please remove these aliases...

[Fl4t]

+1

If I repeat the keystroke j (or k) infinitely, no input apear since I release these keys. This kind of moment appear after using git log or less, man witch use it to scroll down/up the terminal.

[sorin-ionescu]

Ok. I'll remove it.