Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Git action styles #244

Closed
sorin-ionescu opened this issue Aug 23, 2012 · 5 comments
Closed

Add Git action styles #244

sorin-ionescu opened this issue Aug 23, 2012 · 5 comments

Comments

@sorin-ionescu
Copy link
Owner

Right now, it is not possible to style Git actions am, cherry-pick, merge, rebase, etc. using any word, letter or unicode pictogram because the identifiers are hard coded in the _git-action function.

Should I add zstyles to remedy this?

@ColinHebert
Copy link
Contributor

I don't think a lot of people use the git actions feature, while improving it could be nice, I don't think you should bother with that (unless someone actually wants this feature)

@sorin-ionescu
Copy link
Owner Author

I disagree. Everybody does merges. A few do rebases. I do interactive rebases all the time. Furthermore, everyone who trades patches via mailing lists uses git-am.

On Aug 24, 2012, at 5:25, Colin Hebert [email protected] wrote:

I don't think a lot of people use the git actions feature, while improving it could be nice, I don't think you should bother with that (unless someone actually wants this feature)


Reply to this email directly or view it on GitHub.

@ColinHebert
Copy link
Contributor

I think I wasn't really clear; I didn't mean to say that nobody uses am, cherry-pick, merge, rebase, etc. I meant that I don't think that many people use the git action "status" in the prompt.

AFAIK, only two themes actually use git-info, because most themes consider that vcs_info gives enough information, and for the few which really use git-info I'm not sure there is a need to customise how the action status is displayed.

I could be wrong, but I think that it would preferable to work on that when someone asks for this feature specifically.

@sorin-ionescu
Copy link
Owner Author

I suppose, it would look something like the following.

zstyle ':prezto:module:git' action 'action:%s'
zstyle ':prezto:module:git:action' am 'am'
zstyle ':prezto:module:git:action' bisect 'bisect'
zstyle ':prezto:module:git:action' cherry-pick 'cherry'
zstyle ':prezto:module:git:action' cherry-pick-sequence 'cherry-seq'
zstyle ':prezto:module:git:action' merge 'merge'
zstyle ':prezto:module:git:action' rebase 'rebase'
zstyle ':prezto:module:git:action' rebase-interactive 'rebase-i'
zstyle ':prezto:module:git:action' rebase-merge 'rebase-m'

@ColinHebert
Copy link
Contributor

Ah, this wasn't what I expected at all. I thought you wanted to create zstyle ':prezto:module:git' am, etc. to replace action (that was silly of me actually...).

This is a good idea (now that I understand what it is exactly)

Fl4t pushed a commit to Fl4t/prezto that referenced this issue Oct 6, 2012
taybin pushed a commit to taybin/prezto that referenced this issue Oct 8, 2012
* upstream/master: (56 commits)
  Replace table captions with headings
  Replace z with fasd in modules README
  [Fix sorin-ionescu#244] Add Git special action styles
  Simplify git-log zstyle documentation
  Fix the name of the theme setup function in READMEs
  [Fix sorin-ionescu#96] Add documentation for git
  Add zstyles for git-log formats
  Rename gk prefixed aliases to gC
  Rename git-info zstyle patterns
  Rename python-info zstyle patterns
  Rename ruby-info zstyle patterns
  Rename editor-info zstyle patterns
  Rename the Git status ignore submodules zstyle pattern
  Rename aliases gSu to gSI and gSU to gSu
  Rename the alias gsc to gsX
  Remove the gig alias
  Fix SSH-Agent casing in README
  [Fix sorin-ionescu#300] Disable SSH-Agent protocol emulation by default
  Update external completions
  [Fix sorin-ionescu#129, Fix sorin-ionescu#211] Add fasd
  ...
lildude pushed a commit to lildude/prezto that referenced this issue Jan 12, 2014
lackac pushed a commit to lackac/prezto that referenced this issue Jan 19, 2014
kodelint pushed a commit to kodelint/prezto that referenced this issue Nov 15, 2016
Revert "Add completion for pass (password-store)"
rooney pushed a commit to rooney/prezto that referenced this issue Aug 19, 2020
RIT80 pushed a commit to RIT80/prezto that referenced this issue Jan 25, 2022
RIT80 added a commit to RIT80/prezto that referenced this issue Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants