-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merging the alias and utility modules #149
Comments
I'm not sure that's a good idea. Having that means that functions defined in this module can't have completion at all, because completion must be loaded after the current The big advantage of |
I was thinking of moving the |
Well, we should always use _foo files anyway, it's just that writing them is annoying. It could be a good policy to just say "no calls to |
* prompt/external/pure 0421252...dec0253 (26): > Update oh-my-zsh instructions > 1.2.0 > Bump zsh-async to 1.0.0, prevents mixed stdout/stderr > Merge pull request sorin-ionescu#153 from sindresorhus/preprompt-update-fix > Merge pull request sorin-ionescu#149 from mafredri/pure-nitro > Close sorin-ionescu#147 PR: Preserve preprompt on Ctrl+L. Fixes sorin-ionescu#145 > Remove cr from prompt_opts, fixes sorin-ionescu#127 > Merge pull request sorin-ionescu#142 from zmwangx/string-length-fix > Merge pull request sorin-ionescu#144 from zmwangx/rename-prompt-to-preprompt > Default to 0 for git rev-list left and right. Fixes sorin-ionescu#137. > Close sorin-ionescu#140 PR: Add git arrows customization. Fixes sorin-ionescu#139. > 1.1.1 > Disable prompt expansion for running command > Merge pull request sorin-ionescu#130 from zmwangx/rename-variables-for-readability > Use standard `[[ ]]` for conditional and add clarifications > fix: do the PURE_GIT_PULL check in the correct place > 1.1.0 > Close sorin-ionescu#124 PR: Show hostname in terminal title if session is over ssh. > Merge pull request sorin-ionescu#125 from sindresorhus/dirty-check > import bug-fix release from zsh-async, fixes async job flushing > readme: faq clarificaitons > readme: add zpty error to faq with explanation and potential solutions > readme: update instructions for antigen and oh-my-zsh. remove incompatible async.plugin.zsh > use cd -q to prevent hooks from firing > prevent git status leakage when testing if dirty > fix paths that are split due to spaces in directory names
Based on a patch by George Angelopoulos <[email protected]>. Closes sorin-ionescu#149.
alias
does not contain strictly aliases but also functions, andutility
does not contain utility functions such as, for example, administrative functions that would create users, directory hierarchies, and copy dot files; instead it contains aliases and alias-like functions. In fact, these two modules used to be a single file that was split for no reason other than that OMZ Robby had afunctions.zsh
file that at the time I thought should be populated.There are three options available:
alias
intoutility
.utility
intoalias
.alias
andutility
into a new module.I'm leaning towards 3 since, again, the code contains neither just aliases nor just functions, but a mix of both. At the moment, I cannot think of a good name.
The text was updated successfully, but these errors were encountered: