Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --reset-author flag #148

Merged
merged 3 commits into from
Sep 3, 2019
Merged

Add --reset-author flag #148

merged 3 commits into from
Sep 3, 2019

Conversation

sorenlouv
Copy link
Owner

@sorenlouv sorenlouv commented Sep 1, 2019

Closes #146

Add --reset-author flag which makes it possible to change the commit author to yourself.
This is useful when the original commit was made by a bot and the the CLA check needs to be bypassed.

Example usage:

backport --reset-author

@spalger

@sorenlouv sorenlouv force-pushed the add-reset-author-flag branch from 4ed072d to 3d28d41 Compare September 1, 2019 08:25
@spalger
Copy link
Contributor

spalger commented Sep 3, 2019

LGTM, tested with elastic/kibana#44717, but I used the documented --resetAuthor flag, do both kebab and camel case flags work?

@sorenlouv
Copy link
Owner Author

sorenlouv commented Sep 3, 2019

I used the documented --resetAuthor flag, do both kebab and camel case flags work?

@spalger Good point. Yes both work due to the way yargs-parser works.

I've now replaced --resetAuthor with --reset-author in the docs for consistency. I've also added a test that verifies this behaviour on the cli level.

@sorenlouv sorenlouv force-pushed the add-reset-author-flag branch from 47c58ae to 2676177 Compare September 3, 2019 22:38
@sorenlouv sorenlouv merged commit 79fdc7c into master Sep 3, 2019
@sorenlouv sorenlouv deleted the add-reset-author-flag branch September 3, 2019 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --reset-author flag
2 participants