Update Links to be more descriptive, View in Salesforce #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My my initial view this is a very good extension, thanks for sharing.
The first thing I see could be easily updated is your Object Name link for going the Object Manager. This can be more descriptive. Second when you find an object from the popup there should be a link to take you to "View in Salesforce" from the popup versus having to go "Show all the Data" and then click "View in Salesforce"
I am not a master JS dev so I did not Export the function isRecordId I just copied it from the data-import.js. This is not CLEAN code so any suggestions to export this function or put it in a Helper somewhere will be helpful and I will do another commit with that change.
Thanks!