Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom commands #139

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Custom commands #139

wants to merge 7 commits into from

Conversation

AziEI
Copy link

@AziEI AziEI commented May 4, 2019

This allows user to set a hotkey to open/close salesforce inspector menu.
If merged, could be implemented to CtrlSpace in Data Export as well.

@jesperkristensen
Copy link
Collaborator

Hi. Thanks for the PR. There is a lot of changes to review, and I haven't looked at all of it. First thing I noticed is that you seem to have removed lazy loading of the popup. I think this goes against the first design principle. https://github.com/sorenkrabbe/Chrome-Salesforce-inspector#design-principles Because the popup runs a lot of JavaScript when it loads, which could slow other things down, and because it makes queries to the Salesforce API when it loads, which could then affect your Salesforce limits even when you are not using the inspector.

@AziEI
Copy link
Author

AziEI commented May 6, 2019

Looks like you're right. Will fix it soon.

@AziEI AziEI force-pushed the custom_commands branch from 72273fd to 3eadb0a Compare May 6, 2019 21:46
@AziEI
Copy link
Author

AziEI commented May 6, 2019

@jesperkristensen returned back lazy loading.
I also read the Design Principles, looks like I'm following them.

@AziEI
Copy link
Author

AziEI commented Dec 12, 2019

@jesperkristensen , @sorenkrabbe any way to merge it please?

@mhousaini
Copy link

Is this functionality available yet?

Is it possible to press a keyboard shortcut to open the Salesforce Inspector menu?

@mhousaini-aware
Copy link

Have you given up on this @jesperkristensen, @sorenkrabbe?

Having the ability to open the SF Inspector panel using a keyboard shortcut is a simple but great improvement.

@tprouvot
Copy link

tprouvot commented Jul 25, 2022

Have you given up on this @jesperkristensen, @sorenkrabbe?

Having the ability to open the SF Inspector panel using a keyboard shortcut is a simple but great improvement.

@mhousaini-aware Have you tried those shortcut ?

image

@mhousaini-aware
Copy link

Have you given up on this @jesperkristensen, @sorenkrabbe?
Having the ability to open the SF Inspector panel using a keyboard shortcut is a simple but great improvement.

@mhousaini-aware Have you tried those shortcut ?

@tprouvot thanks for responding, that doesn't work. In your original comment, you suggested alt + i, and it works for me!

I've also noticed a few other issues in relation to the keyboard shortcuts, I'll list them here for your reference - from least to most important.

  1. The [ctrl+alt+i] to open text should be updated to [alt + i].
  2. It would be nice if pressing [alt + i] again would close the panel, instead of launching the Data Import tool.
  3. It would be fantastic if there was an option to use keyboard shortcuts after opening the panel to open the subsequent tool (show all data, data import, data export, org limits) in a new tab (currently it opens in the same tab). For instance, it could open in a new tab if you also press Shift.
  4. There doesn't seem to be a shortcut for the Show all data option after the panel has opened - pressing alt + a doesn't do anything even though the letter a is underlined. In my experience, this is the most common option that people choose after opening the panel, so this would be a welcome addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants