Support D-Bus secret service via libsecret #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
eagletmt
commented
Jun 7, 2016
eagletmt
commented
- Extract platform-independent API:
- envchain_search_namespaces
- envchain_search_values
- envchain_save_values
- Implement those APIs for Linux using D-Bus secret service
|
|
||
| void envchain_save_value(const char *name, const char *key, char *value, | ||
| G_GNUC_UNUSED int require_passphrase) { | ||
| /* TODO: Support require_passphrase flag */ |
There was a problem hiding this comment.
I'm not sure if this is possible or not
|
lgtm? |
eagletmt
force-pushed
the
linux
branch
2 times, most recently
from
869a20c
to
447c038
Compare
|
I believe it's working well now. |
|
LGTM |
- Extract platform-independent API: - envchain_search_namespaces - envchain_search_values - envchain_save_values - Implement those APIs for Linux using D-Bus secret service
|
squashed |
sorah
added a commit
that referenced
this pull request
Jun 8, 2016
= New feature - Linux support with libsecret (#7 @eagletmt) libsecret commuicates with D-Bus secret service; for instance, gnome-keyring implements it. = New feature in v0.2.0 (forgot to note..) - `--list` command On OS X keychain, values have to be set after envchain v0.2.0 or later due to data structure change, in prior to be listed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.