Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metadata fetching #700

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Merge branch 'master' into feature/connection-metadata

41cadf3
Select commit
Loading
Failed to load commit list.
Draft

add metadata fetching #700

Merge branch 'master' into feature/connection-metadata
41cadf3
Select commit
Loading
Failed to load commit list.
Soramitsu-Sonar-PR-decoration / sora2-substrate-js-library Sonarqube Results failed Dec 12, 2023 in 15s

Quality Gate failed

Failed

  • 0.00% Coverage on New Code (is less than 80.00%)
  • 0.00% Security Hotspots Reviewed on New Code (is less than 100.00%)

Analysis Details

3 Issues

  • Bug 0 Bugs
  • Vulnerability 1 Vulnerability
  • Code Smell 2 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (0.10% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: sora2:sora2-substrate-js-library

View in SonarQube

Annotations

Check failure on line 11 in packages/connection/src/http.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/connection/src/http.ts#L11

Make sure the regex used here, which is vulnerable to super-linear runtime due to backtracking, cannot lead to denial of service.

Check warning on line 125 in packages/connection/src/connection.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/connection/src/connection.ts#L125

This assertion is unnecessary since it does not change the type of the expression.

Check warning on line 118 in packages/connection/src/connection.ts

See this annotation in the file changed.

@soramitsu-sonar-pr-decoration soramitsu-sonar-pr-decoration / sora2-substrate-js-library Sonarqube Results

packages/connection/src/connection.ts#L118

This assertion is unnecessary since it does not change the type of the expression.