모달 관련 오류 해결 #427
Merged
모달 관련 오류 해결 #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
d66f2f2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f22aae65.sopt-crew-dev-legacy.pages.dev |
| Branch Preview URL: | https://feat--424.sopt-crew-dev-legacy.pages.dev |
borimong
reviewed
Sep 18, 2023
| <ModalBackground /> | ||
| <Dialog.Panel>{children}</Dialog.Panel> | ||
| </Dialog> | ||
| <Show |
There was a problem hiding this comment.
이렇게 fallback 으로 조건부 렌더링하는 거 흥미롭다..!!
eunsukimme
approved these changes
Sep 24, 2023
There was a problem hiding this comment.
요거는 overlay provider랑 headless-ui를 같이 쓸때 스크롤 안되는 이슈를 예방하기 위해 필요한 것이라고 하여 남겨둡시다
na-reum
had a problem deploying
to
development
GitHub Actions
Failure
na-reum
had a problem deploying
to
development
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📋 작업 내용
📌 PR Point
headlessUi의Dialog컴포넌트는 컴포넌트 상에 Nesting을 해주면 중첩모달의 동작이 정상적으로 이루어짐을 알아냄📸 스크린샷