Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enter room logic and delet some comments #133

Merged
merged 4 commits into from
May 7, 2024
Merged

Fix enter room logic and delet some comments #133

merged 4 commits into from
May 7, 2024

Conversation

Haaaan1
Copy link
Contributor

@Haaaan1 Haaaan1 commented May 7, 2024 •
edited
Loading

  1. Fix enter in-game room guard Modify UI in Lobby page #107
  2. Add toast notify when enter room Change all alerts into toast pop-up in lobby page #101

@Haaaan1 Haaaan1 requested a review from petertheprocess May 7, 2024 08:20
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

petertheprocess
petertheprocess approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@petertheprocess petertheprocess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fixed empty username bug.

@petertheprocess petertheprocess merged commit fe44a81 into dev May 7, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertheprocess petertheprocess petertheprocess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Haaaan1 @petertheprocess