Skip to content

Commit

Permalink
[fix] 1.fix eslint err 2.remove npm run test in github action
Browse files Browse the repository at this point in the history
  • Loading branch information
petertheprocess committed Apr 25, 2024
1 parent 2d0d046 commit 097325e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/build_test_before_pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,3 @@ jobs:
node-version: "20.x"
- run: npm install
- run: npm run build

- name: Test
run: npm test
3 changes: 2 additions & 1 deletion src/components/views/Gameroom.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -605,6 +605,7 @@ const Gameroom = () => {
if (!gameInfo) {
return <div>loading...</div>;
}

return (
<>
<div className="gameroom roundstatus">
Expand Down Expand Up @@ -778,7 +779,7 @@ const Gameroom = () => {
ref={_audioRecorderRef}
className="gameroom audiorecorder"
ffmpeg={ffmpegObj}
audioName={`my_recording`}
audioName={"my_recording"}
handleReversedAudioChange={handleAudioReversed}
/>
</div>
Expand Down
5 changes: 2 additions & 3 deletions src/components/views/Lobby.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import React, { useRef, useEffect, useState } from "react";
import { api, handleError } from "helpers/api";
import { Spinner } from "components/ui/Spinner";
import { Button } from "components/ui/Button";
import { useNavigate } from "react-router-dom";
import BaseContainer from "components/ui/BaseContainer";
Expand Down Expand Up @@ -234,7 +233,7 @@ const Lobby = () => {

const createRoom = async () => {
try {
console.log('Current theme:', roomTheme);
console.log("Current theme:", roomTheme);
const ownerId = sessionStorage.getItem("id"); // 假设ownerId存储在sessionStorage中
const requestBody = JSON.stringify({
roomName: roomName,
Expand Down Expand Up @@ -484,7 +483,7 @@ const Lobby = () => {
value={numRounds}
onChange={e => {
const value = parseInt(e.target.value, 10);
setNumRounds(value >= 2 && value <= 10 ? value : '');
setNumRounds(value >= 2 && value <= 10 ? value : "");
}}
min={2}
max={10}
Expand Down

0 comments on commit 097325e

Please sign in to comment.