forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Auto merge of rust-lang#36117 - eddyb:llvm-hoist-meta, r=alexcrichton
llvm: backport "[SimplifyCFG] Hoisting invalidates metadata". Fixes rust-lang#36023 by backporting @majnemer's LLVM patch fixing [the LLVM bug](https://llvm.org/bugs/show_bug.cgi?id=29163.) where SimplifyCFG hoisted instructions andkept their metadata (conditional `!nonnull` loads could kill a null check later if hoisted). r? @alexcrichton
- Loading branch information
Showing
3 changed files
with
34 additions
and
2 deletions.
There are no files selected for viewing
Submodule llvm
updated
2 files
+8 −2 | lib/Transforms/Utils/SimplifyCFG.cpp | |
+31 −0 | test/Transforms/SimplifyCFG/PR29163.ll |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
# If this file is modified, then llvm will be forcibly cleaned and then rebuilt. | ||
# The actual contents of this file do not matter, but to trigger a change on the | ||
# build bots then the contents should be changed so git updates the mtime. | ||
2016-08-17 | ||
2016-08-23 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
// Copyright 2016 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
use std::ops::Deref; | ||
|
||
fn main() { | ||
if env_var("FOOBAR").as_ref().map(Deref::deref).ok() == Some("yes") { | ||
panic!() | ||
} | ||
|
||
let env_home: Result<String, ()> = Ok("foo-bar-baz".to_string()); | ||
let env_home = env_home.as_ref().map(Deref::deref).ok(); | ||
|
||
if env_home == Some("") { panic!() } | ||
} | ||
|
||
#[inline(never)] | ||
fn env_var(s: &str) -> Result<String, VarError> { | ||
Err(VarError::NotPresent) | ||
} | ||
|
||
pub enum VarError { | ||
NotPresent, | ||
NotUnicode(String), | ||
} |