Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds benchmarks #26

Closed
wants to merge 1 commit into from
Closed

Adds benchmarks #26

wants to merge 1 commit into from

Conversation

FilipAndersson245
Copy link
Contributor

As one of the reason for the rewrite is performance, I Think its good to have a track record of the performance somewhere, this is two simple benchmark added in this PR, one that create a deeply nested record, a second that construct a small table with multiple different types. I initially wanted to add the current env.nu and config.nu but it the parser panics when I tried to parse them.

@fdncred
Copy link

fdncred commented Mar 26, 2024

Agreed. I think it's good to start somewhere with benchmarks. What would be even better would be if the results are stored somewhere in a csv or nuon file so we could look at the changes over time.

@FilipAndersson245
Copy link
Contributor Author

Agreed. I think it's good to start somewhere with benchmarks. What would be even better would be if the results are stored somewhere in a csv or nuon file so we could look at the changes over time.

Yes, Divan is currently working creating a file based format when that is completed I think we should setup something that continuously track the performance, I would love if we could have a regression test in performance on PR in nutshell for example simular to how Rustlang does it but maybe on a smaller scale.

@FilipAndersson245 FilipAndersson245 deleted the benchmarks branch May 29, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants