-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve #926 #927
Resolve #926 #927
Conversation
Also cleaned up dict value retrieval a little, the .get() calls were a bit unnecessary.
Should probably be squashed into a single commit that says "Removed feedparser dependency (closes #926)" or something like that. But 👍 |
But muh commiting from github web |
That sounds painful lol |
The |
Ah good call, didn't even think about that. Should I edit this PR or create a new one to add them back in? |
You can just edit this one. Thanks! |
There's some places where there were already try catch blocks for KeyError, so I left those ones.
I got this exception while testing this with
|
Yeaaaah, don't ask how that one slipped through. |
Thanks! |
Also cleaned up dict value retrieval a little, the .get() calls were a bit unnecessary.