Improve code for translation module #474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a note indicating that the API is no longer functional
|
"No longer works"? In that case, why would we pull this? |
|
@elad661 Perhaps my comment was misleading. It is not that the code is broken -- |
|
See also: https://developers.google.com/translate/v2/pricing. Translation is a paid API now. |
|
Well, yes, it's a paid API, but willie is not exactly using this API. And it does work on master, I just tested. Not merging as you claiming this doesn't work means you didn't even test your own code. |
|
I'm working on a pull request to add support for Travis CI. The tests fail there, too. |
|
Then your tests are broken, not our code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a note indicating that the API is no longer functional