bot, coretasks, url: search_url_callbacks() as a public wrapper
#2585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actual implementation lives in a private method that can be called internally without raising a deprecation warning.
Core/builtin code bypasses the deprecation warning that will start in Sopel 8.1 this way (the public method isn't being removed until 9.0).
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #2581, which will let us keep using the deprecated mechanism internally without logging warnings about it, while warning third party plugin authors as expected.
Checklist
make qa(runsmake lintandmake test)I don't remember if I ran the linter/tests when making this branch a couple days ago, so I won't check those boxes just yet. 😅 Plenty of time to sort it out, as this will be an 8.1 change.