Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

currency: add .currencies command to list supported symbols #2439

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

dgw
Copy link
Member

@dgw dgw commented Mar 31, 2023

Description

Title. Sends to PM, because the list could be quite long.

Currently allows for up to 5 messages' worth of ticker symbols.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw dgw added the Feature label Mar 31, 2023
@dgw dgw added this to the 8.0.0 milestone Mar 31, 2023
@dgw dgw requested a review from a team March 31, 2023 17:10
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even tho I have a nitpick, I think it can go like that anyway.

sopel/modules/currency.py Outdated Show resolved Hide resolved
Sends to PM, because the list could be quite long.

Currently allows for up to 5 messages' worth of currency codes..
@dgw dgw force-pushed the currency-list-supported branch from 5eeaf55 to 995fb11 Compare April 1, 2023 12:11
@dgw dgw merged commit 9a286e9 into master Apr 9, 2023
@dgw dgw deleted the currency-list-supported branch April 9, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants