pronouns: make base URL of links configurable #2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we maintain a fork of svelte-pronounisland, it's not that big of a jump for bot owners to want a vanity instance tied to their communities. This is a simple configuration option to offer. It would be equally simple (but more annoying) to have a second setting that allows overriding the URL for the `.tab` file containing all known pronoun sets, used when `fetch_complete_list` is True. Won't cause any problems unless we make frequent updates to our fork that aren't picked up automatically by downstream users.
Exirel
approved these changes
Mar 28, 2023
SnoopJ
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the option to use "your own domain" for the pronoun-info links output by the
pronounsplugin.Since it's so easy for us to host our own
pronoun.isclone, that means it's also easy for our users to do so. I think bot owners having the ability to choose how this plugin's links look is very much in keeping with the plugin's spirit, and it's simple to do.This is a follow-up to #2437—and by rights should have been done in #2437, but I didn't think of it yet.
Checklist
make qa(runsmake qualityandmake test)1430 passed, 8 xfailed, 1 warning in 38.28s