Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py, build: drop py plugin from core & require external package #2411

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Conversation

dgw
Copy link
Member

@dgw dgw commented Feb 13, 2023

Description

default='https://oblique.sopel.chat/')

This Oblique service URL will stop working at some point. End of support for Python 2.7 on Google App Engine, in January 2024, approaches. After that point we'll be unable to update that deployment. https://github.com/sopel-irc/oblique is already archived, because we're not intending to update it (the package contains a lot more than just the py service).

Dropping this plugin from core now will let us make the transition to a new backend easier, without having to fit it into Sopel's release cadence. Marked the requirement with a TODO for 8.1, when it should become an optional manually-installed plugin like the others that have been packageized (ipython, spellcheck, etc.).

While there is a pylambda private repo with a potential replacement, it makes more sense to just drop this from the first-party features. Among users active in the #sopel channel, this plugin only seems to come up when someone's bot's users notice it in the command listing and start trying to break it.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

Notes

Plugin moved to https://github.com/sopel-irc/sopel-py

@dgw dgw added Breaking Change Stuff that probably should be mentioned in a migration guide Housekeeping Code cleanup, removal of deprecated stuff, etc. labels Feb 13, 2023
@dgw dgw added this to the 8.0.0 milestone Feb 13, 2023
@dgw dgw requested a review from a team February 13, 2023 00:02
@dgw
Copy link
Member Author

dgw commented Feb 13, 2023

Damn it, pip, I want prerelease versions to be allowed. Will have to tweak the new package, republish, and rerun checks. 😩

@dgw dgw force-pushed the rm-py branch 2 times, most recently from 8b8cafe to 238c19c Compare February 13, 2023 00:20
End of support for Python 2.7 on Google App Engine, in January 2024,
approaches. Dropping this plugin from core now will let us make the
transition to a new backend easier, without having to fit it into
Sopel's release cadence.

Marked the requirement with a TODO for 8.1, when it should become an
optional manually-installed plugin like the others that have been
packageized (ipython, spellcheck, etc.).
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be so happy when we reach Sopel 8.1's release day.

@dgw dgw merged commit 295a73f into master Feb 20, 2023
@dgw dgw deleted the rm-py branch February 20, 2023 03:40
@dgw dgw mentioned this pull request Jul 3, 2023
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Stuff that probably should be mentioned in a migration guide Housekeeping Code cleanup, removal of deprecated stuff, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants