Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rules: drop draft/bot tag #2272

Merged
merged 1 commit into from
May 12, 2022
Merged

rules: drop draft/bot tag #2272

merged 1 commit into from
May 12, 2022

Conversation

dgw
Copy link
Member

@dgw dgw commented Apr 26, 2022

Description

Bot Mode spec has been ratified (ircv3/ircv3-specifications#495). Since we haven't published a release with support for this message tag yet, it's a very easy decision to take right now that we'll only support the finalized spec and not the WIP version.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

Bot Mode spec has been ratified (ircv3/ircv3-specifications#495). Since
we haven't published a release with support for this message tag yet,
it's a very easy decision to take *right now* that we'll only support
the finalized spec and not the WIP version.
@dgw dgw added the Tweak label Apr 26, 2022
@dgw dgw added this to the 8.0.0 milestone Apr 26, 2022
@dgw dgw requested a review from a team April 26, 2022 23:33
@half-duplex
Copy link
Member

What implements the draft version? How safe is the assumption that they'll all switch to the final spec/tag promptly? Otherwise I'm not sure there's a reason to drop the draft one.

@dgw
Copy link
Member Author

dgw commented Apr 27, 2022

The top comment of the linked IRCv3 PR is a non-exhaustive list of existing implementations that may or may not have yet switched to the final tag name. There are 8 servers/clients listed, including Sopel itself. However, since the server adds the message tag, the client implementations are irrelevant to this decision. That leaves just 3 IRCds with draft impls to consider.

Pushing to ratify the spec this week was because InspIRCd wanted to ship the feature in a release on Friday, 4/29. It's safe to assume they will use the final tag name. The other servers will almost certainly release new versions with this feature in its final state before Sopel 8.0 is done. (They all have much better release cadences than we do…)

In this specific case there are no meaningful differences between the draft and final specs, but in general it's improper to implement a WIP spec as I did in #2089, where it responds to both the prefixed and unprefixed tag names.

Copy link
Member

@half-duplex half-duplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. We also have +B, and that's probably all anyone should be relying on until they've got the final bot mode cap.

sopel/plugins/rules.py Show resolved Hide resolved
@dgw dgw merged commit d7dc478 into master May 12, 2022
@dgw dgw deleted the bot-mode-ratified branch May 12, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants