Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: move memory classes to tools.memories #2237

Merged
merged 2 commits into from
Feb 24, 2022
Merged

tools: move memory classes to tools.memories #2237

merged 2 commits into from
Feb 24, 2022

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Jan 15, 2022

Description

And also uses SopelIdentifierMemory into target.Channel.

Based on #2236 (chekc only the last two commits).

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added the Tweak label Jan 15, 2022
@Exirel Exirel added this to the 8.0.0 milestone Jan 15, 2022
@Exirel Exirel mentioned this pull request Jan 15, 2022
Merged
4 tasks
@Exirel Exirel force-pushed the tools-memories branch 2 times, most recently from 00ed477 to 2a06736 Compare January 25, 2022 21:53
@Exirel Exirel marked this pull request as ready for review January 25, 2022 21:54
@Exirel Exirel requested a review from a team January 26, 2022 12:45
dgw
dgw reviewed Jan 27, 2022
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got sidetracked before actually submitting these, but... now it's boring meeting o'clock. 😝

sopel/tools/memories.py Outdated Show resolved Hide resolved
sopel/tools/memories.py Show resolved Hide resolved
sopel/tools/memories.py Show resolved Hide resolved
sopel/tools/memories.py Show resolved Hide resolved
sopel/tools/__init__.py Show resolved Hide resolved
@Exirel Exirel requested a review from dgw February 9, 2022 21:26
dgw
dgw approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@dgw dgw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting squash. :shipit:

@Exirel if you want, s/into Channel/in Channel object/ for the commit message of that second change.

@Exirel
Copy link
Contributor Author

Exirel commented Feb 17, 2022

Rebased & squashed + reworked the commit message.

@Exirel Exirel mentioned this pull request Feb 18, 2022
Merged
4 tasks
@Exirel
Copy link
Contributor Author

Exirel commented Feb 23, 2022

I'm going to rebase that to fix the merge conflict.

Exirel and others added 2 commits February 23, 2022 10:41
@Exirel @dgw
tools: move memory classes to tools.memories
9e2e7d0 
Co-authored-by: dgw <[email protected]>
@Exirel
tools.target: use SopelIdentifierMemory in Channel object
b9a1e0c 
Note: it is possible to keep the same type hint because
SopelIdentifierMemory is a subclass of dict.
@dgw dgw merged commit 9944e05 into sopel-irc:master Feb 24, 2022
@Exirel Exirel deleted the tools-memories branch February 24, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Tweak
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Exirel @dgw