db: make database path relative to config.core.homedir
#1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any @sopel-irc/rockstars takers to review this? I'm hoping its pretty straightforward 😁 we shall see... |
|
@HumorBaby doesn't that is in conflict with #1446? |
|
The conflicts look... interesting. Good luck. :-/ |
|
On the plus side, there's only "one" conflict? 😕 |
dgw
added
Stale
HumorBaby
force-pushed
the
refactor-db_filename-dir
branch
from
3b4c0ff to
701be15
Compare
hehe, wasn't too bad actually! RustyB developed around the part I modified 😁 Anyway, the conflict is handled now. |
HumorBaby
removed
the
Stale
Exirel
approved these changes
Aug 14, 2019
Raises `OSError` if the directory in which the database will be created does not exist.
HumorBaby
force-pushed
the
refactor-db_filename-dir
branch
from
2885698 to
6b8afcf
Compare
HumorBaby
added
the
Bugfix
dgw
added
Tweak
and removed
Bugfix
3 tasks
dgw
approved these changes
Aug 27, 2019
| path = os.path.normpath(os.path.join(config_dir, path)) | ||
| path = os.path.normpath(os.path.join(config.core.homedir, path)) | ||
| if not os.path.isdir(os.path.dirname(path)): | ||
| raise OSError( |
There was a problem hiding this comment.
I could bikeshed this and say we should use FileNotFoundError, but 💤. It's an easy change to make later if we really want to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the default base directory for the database
core.homedir. Non-absolute paths are relative to that directory, as opposed to previously, where they were relative to the config file path.Additionally, now
SopelDB.__init__willraise OSErrorif the directory in which the database is to be created does not exist.Closes #1047.