coretasks: fix malformed MODE command in startup() #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bot.write() joins the elements of a sequence type (tuple, here) with a space already, so including a space in `'MODE '` caused Sopel to send `MODE SopelsNick +modes`. Technically, that's invalid. Discovered while trying to test #1470 on a network with actual support for `echo-message`, when darwin.network disconnected the bot during registration with the message "ERROR :Received malformed line". Annoying because I was trying to test something else, but useful in the end.
Exirel
approved these changes
Apr 5, 2019
dgw
added a commit
that referenced
this pull request
Apr 9, 2019
Just like #1544, but in the `admin.py` module instead of coretasks. This was the only relevant occurrence I could find with a search for strings with trailing spaces. Hopefully after this, we're golden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bot.write()joins the elements of a sequence type (tuple, here) with a space already, so including a space in'MODE 'caused Sopel to sendMODE SopelsNick +modes. Technically, that's invalid.Discovered while trying to test #1470 on a network with actual support for
echo-message, when darwin.network disconnected the bot during registration with the message "ERROR :Received malformed line". Annoying because I was trying to test something else, but useful in the end.