-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sopel.cli.utils #1472
sopel.cli.utils #1472
Conversation
9e9545d
to
383349d
Compare
Oh, so in Py2, the subparser action is mandatory... interesting! |
383349d
to
1d1e313
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once again, the majority of line notes are related to docstrings.
There are relatively more larger questions in this review, though. That's why it's a "Comment" instead of "Request changes"—the changes I might request aren't defined yet.
f2770ac
to
4f7e500
Compare
@dgw should be good for one last review. |
4f7e500
to
2bf5e05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to #1471:
sopel.cli.utils
modules,sopel.cli.utils
are available fromsopel.cli
as shortcuts,sopel.cli.utils
,sopel.run_script
now usessopel.cli.utils
for these functions,test/cli/test_cli_utils.py
for consistency,and there is no new feature, only internal changes: everything is backward compatible.
From this PR, it is possible to change how settings are loaded (which files, from where, etc.), and there is one single place to load a Sopel's configuration.