Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xkcd: Change search engine from Duckduckgo to Bing #1410

Merged
merged 1 commit into from
Dec 28, 2018

Conversation

kwaaak
Copy link
Contributor

@kwaaak kwaaak commented Nov 12, 2018

For whatever reason Duckduckgo (which is used when it says google_search in this module) does not return results anymore. A quick switch to Bing restores the search function.

For whatever reason Duckduckgo (which is used when it says google_search in this module) does not return results anymore. A quick switch to Bing restores the search function.
@kwaaak kwaaak changed the title Change search engine from Duckduckgo to Bing xkcd: Change search engine from Duckduckgo to Bing Nov 12, 2018
@dgw
Copy link
Member

dgw commented Nov 13, 2018

DuckDuckGo no longer returns results when multiple site: operators are present in the query, on its plain HTML version (https://duckduckgo.com/html/). The xkcd module uses a bunch of negative -site: operators to try and get comics only, and for whatever reason DDG stopped working for that case.

I reached out to DuckDuckGo via feedback and social media; we'll see if they address it. I consider this ultimately a "bug" in the search module (even though it's not Sopel's fault), but if all else fails and DDG won't address the issue then this patch is a good fallback for the next release.

Thanks for bringing the problem to my attention!

@dgw dgw added the Bug Things to squish; generally used for issues label Nov 13, 2018
@dgw dgw added this to the 6.6.0 milestone Nov 13, 2018
@dgw dgw self-assigned this Nov 13, 2018
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will work. See #1415 for merge/release plans and further information on the bug that makes this change necessary.

@dgw
Copy link
Member

dgw commented Dec 28, 2018

DuckDuckGo isn't showing any signs of even acknowledging the site: bug's existence. Unless they suddenly decide to fix it, this workaround will be released with the next version of Sopel.

@dgw dgw merged commit b1643f1 into sopel-irc:master Dec 28, 2018
@kwaaak kwaaak deleted the patch-4 branch January 2, 2019 17:11
@dgw dgw added Bugfix Generally, PRs that reference (and fix) one or more issue(s) and removed Bug Things to squish; generally used for issues labels Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants