Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reddit Module Posts Output 3 Times if a Reddit Short Link is posted in Chat #615

Closed
slamanna212 opened this issue Sep 1, 2014 · 2 comments
Closed

Reddit Module Posts Output 3 Times if a Reddit Short Link is posted in Chat #615

slamanna212 opened this issue Sep 1, 2014 · 2 comments
Labels
Bug Things to squish; generally used for issues

Comments

@slamanna212
Copy link

Title says it all, every time a reddit short link is posted in IRC it then shows the post info 3 times, example here:

http://i.imgur.com/jRcQQat.png
@tyrope tyrope added the Bug label Sep 1, 2014
@embolalia
Copy link
Contributor

In the future, please paste your output rather than screenshotting. That way I can copy-paste the URL, rather than having to retype it manually.

Also, I'm only getting the output twice. Could you paste the output of .version? (I assume it's either 4.5.0 or a recent -git, but it's still good to know.)

embolalia added a commit that referenced this issue Sep 1, 2014
@embolalia
[bugzilla, github, reddit, youtube] Remove handlers on shutdown
8dc0741 
This solves #615. When reloading these modules, a new compiled regex
object was created and inserted into the url handler set. Because it was
a new object, it didn't replace the old one (even though the pattern was
the same). This meant that every time the module was reloaded, another
version of the function was added, meaning the output would be produced
an additional time.
@embolalia
Copy link
Contributor

Fixed in de4abaa, but if you don't want to run from git you can also fix this by turning it off and turning it back on again :D

embolalia added a commit that referenced this issue Sep 1, 2014
@embolalia
[bugzilla, github, reddit, youtube] Remove handlers on shutdown
de4abaa 
This solves #615. When reloading these modules, a new compiled regex
object was created and inserted into the url handler set. Because it was
a new object, it didn't replace the old one (even though the pattern was
the same). This meant that every time the module was reloaded, another
version of the function was added, meaning the output would be produced
an additional time.
maxpowa pushed a commit to maxpowa/Inumuta that referenced this issue Feb 20, 2015
@embolalia
[bugzilla, github, reddit, youtube] Remove handlers on shutdown
9382a86 
This solves sopel-irc#615. When reloading these modules, a new compiled regex
object was created and inserted into the url handler set. Because it was
a new object, it didn't replace the old one (even though the pattern was
the same). This meant that every time the module was reloaded, another
version of the function was added, meaning the output would be produced
an additional time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Things to squish; generally used for issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tyrope @embolalia @slamanna212