[chanlogs] exceptions with channels that have "/"

[bui]

Traceback (most recent call last):
  File "/home/amphy/willie/willie/bot.py", line 747, in call
    exit_code = func(willie, trigger)
  File "/home/amphy/willie/willie/modules/chanlogs.py", line 115, in log_join
    with open(fpath, "a") as f:
IOError: [Errno 2] No such file or directory: u'/vp/-2014-03-21.log'

I imagine there'll be issues with other characters too, so what can be done about this? I believe ZNC's log module replaces special characters with a ? or _, maybe this should be done here?

[elad661]

This is an interesting one as the list of forbidden characters depend on the filesystem. Since willie can be run on probably any filesystem out there, we need to figure out a list of blacklisted chars and a map of things to replace them with: what happens if a channel is named #foo/bar and another is named #foo?bar, and willie is running on NTFS? we can't change all forbidden chars to one char, because that will cause conflicts.

We need to figure out a better solution. Perhaps url-encoding channel names when they contain an illegal char?

Obviously for ext2/3/4 filesystems we don't have the conflict problem since there are only two forbidden chars: / and NULL, but willie is cross-platform, and there's the possibility some crazy person out there is running willie on FAT16 from Linux.

[embolalia]

I like the idea of URL encoding, although I don't know whether that would play well serving the log dir over http. Would they end up double-encoded? Still, probably better to just do something to stop the errors, even if there's a better way.

[mshade]

As much as I hate suggesting this, I think perfect is the enemy of good in this case, and translating "illegal" characters to something common is probably the best approach. The other alternative would be logging to a database by default, or using a checksum of some sort, which both lead to awful discoverability.

Perhaps use something like __ (double underscore) as the substitution? Be very conservative in which "illegal" characters would trigger it.