Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit on error Command Line flag #273

Closed
tyrope opened this issue May 29, 2013 · 3 comments
Closed

exit on error Command Line flag #273

tyrope opened this issue May 29, 2013 · 3 comments
Labels

Comments

@tyrope
Copy link

tyrope commented May 29, 2013

As suggested by @elad661 for #268
"Run its own willie instance so that we can easily detect commits that breaks the ability of the bot to start and connect. To do that we will need to add a switch willie, something like --exit-on-error to make the bot exit with a predefined code as soon as a core exception is detected."

@ghost ghost assigned elad661 May 31, 2013
elad661 pushed a commit that referenced this issue May 31, 2013
Exit on every core failure, even network disconnect.
This is mostly useful for the automated test-suite we are working on.

Fixes issue #273
@elad661 elad661 closed this as completed May 31, 2013
embolalia added a commit that referenced this issue Mar 25, 2015
Intentionally introducing a regression to simplify the config work. This
reopens #273. When we're actually remotely close to having a plan for
that automated testing, we'll redo something like this (probably in a
better way).
@embolalia embolalia reopened this Mar 25, 2015
@maxpowa
Copy link
Contributor

maxpowa commented Jun 22, 2016

Not sure if this is needed for testing, we're currently able to test a large portion of the bot without actually starting a full instance.

@Exirel
Copy link
Contributor

Exirel commented Jan 12, 2019

If nobody is running the bot to test it, and need this, I think we can close it for now (this comment is not sponsored by the Clean Up Industry, I swear).

@dgw
Copy link
Member

dgw commented Jan 12, 2019

The way testing works now, I agree we don't need this feature. (Thanks for checking old issues, @Exirel!)

@dgw dgw closed this as completed Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants