Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irc.py line 151: can't deal with chinese. utf8 #239

Closed
wxg4net opened this issue Apr 24, 2013 · 4 comments
Closed

irc.py line 151: can't deal with chinese. utf8 #239

wxg4net opened this issue Apr 24, 2013 · 4 comments
Labels
Bug Things to squish; generally used for issues Medium Priority

Comments

@wxg4net
Copy link

wxg4net commented Apr 24, 2013

may be :
string = str(string.decode('utf-8'))

@elad661
Copy link
Contributor

elad661 commented Apr 24, 2013

Can I get a full stacktrace please?

@wxg4net
Copy link
Author

wxg4net commented Apr 24, 2013

于2013年04月24日 星期三 20时42分48秒,Elad Alfassa写到:

Can I get a full stacktrace please?


Reply to this email directly or view it on GitHub
#239 (comment).

take a snapshot :
http://184.82.27.205/tmp/2013-04-24-220345_712x194_scrot.png
(10:03:27 PM) wxg4net: .topic 测试中文
(10:03:28 PM) perhome: UnicodeEncodeError: 'ascii' codec can't encode
characters in position 54-57: ordinal not in range(128) (file
"/home/server/runtimes/willie/willie/irc.py", line 151, in safe)

@tyrope
Copy link

tyrope commented Apr 24, 2013

That's not what @elad661 asked for, there should be an exceptions.log in ~.willie\logs. Please copy the relevant part of that.

@embolalia
Copy link
Contributor

That's okay, we found the bug. 4c6b0d34da93b678c0decbb7ace6240d0418e5b1 fixes it, though it opens up a bunch of other problems we'll have to deal with (see issue #240).

embolalia added a commit that referenced this issue Apr 24, 2013
This will probably break a few things, including the codepoints module.
It also likely means that people still using weird formats like the
assorted weird ISO ones might have unexpected behavior. Too bad. Call me
a zealot but UTF-8 is the closest thing we have, or possibly could have,
to a single standard that actually works for character encoding. It is
the One True Encoding.

This closes issue #239 but opens issue #240
embolalia added a commit that referenced this issue Apr 24, 2013
This will probably break a few things, including the codepoints module.
It also likely means that people still using weird formats like the
assorted weird ISO ones might have unexpected behavior. Too bad. Call me
a zealot but UTF-8 is the closest thing we have, or possibly could have,
to a single standard that actually works for character encoding. It is
the One True Encoding.

This closes issue #239 but opens issue #240
elad661 pushed a commit that referenced this issue Apr 29, 2014
…ited

Fixes #239
If func.rate is zero or None (as None > 0 == False), don't bother going into
the rate limiting code. This prevents the race condition described by @Venti-
in issue #239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Things to squish; generally used for issues Medium Priority
Projects
None yet
Development

No branches or pull requests

4 participants