Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable executing Willie from outside the source directory #153

Closed
embolalia opened this issue Nov 9, 2012 · 4 comments
Closed

Enable executing Willie from outside the source directory #153

embolalia opened this issue Nov 9, 2012 · 4 comments

Comments

@embolalia
Copy link
Contributor

This is something that seems like a minor issue, since we're so used to running willie from its source directory. Nonetheless, as a video @elad661 showed me points out, this isn't something that should be the case for a full-fledged FOSS project. I don't imagine this will be terribly hard to do, but there are some questions about how it should be done.

The primary problem at the moment is that it assumes that modules will be in the modules/ subdirectory of the current directory. Having modules available in the modules/ subdirectory of the source directory makes sense. I wonder, though, if we should enable a default per-user location for additional modules, say ~/.willie/modules, in case someone decides to install Willie system-wide for whatever reason.

embolalia added a commit that referenced this issue Nov 9, 2012
This is a big part of issue #153, but I'd like now to see if we can
figure out how to install it globally.
elad661 pushed a commit that referenced this issue Nov 9, 2012
@elad661
Copy link
Contributor

elad661 commented Nov 9, 2012

Still needs fixing:

  • Make logging path configurable, default to ~/.willie/logs/
  • Move pid files to /run/willie or /var/run/willie
  • Make sure we don't write anything to willie's directory - all files we write during runtime should be in dotdir!
  • Make a distutils based installer

elad661 pushed a commit that referenced this issue Nov 9, 2012
elad661 pushed a commit that referenced this issue Nov 9, 2012
elad661 pushed a commit that referenced this issue Nov 9, 2012
embolalia added a commit that referenced this issue Nov 10, 2012
elad661 pushed a commit that referenced this issue Nov 10, 2012
@elad661
Copy link
Contributor

elad661 commented Nov 10, 2012

config.py line 245 still has os.getcwd(), it seems to be looking for modules there.

Should use os.path.dirname(os.path.abspath(__file__)) instead.

@embolalia
Copy link
Contributor Author

Actually, looking at it, I think it needs to be removed entirely. It uses enumerate_modules to find the filenames. The cwd stuff is added to the path, which I don't think we need or want. Though, it also has trouble configuring modules when run on its own, due to imports in modulues. Should we add another command line option to willie.py to handle running the config script on its own? Split out the wizard into another file for the root directory?

@embolalia
Copy link
Contributor Author

Config util now works as arguments to the main script, so this issue can be closed.

maxpowa pushed a commit to maxpowa/Inumuta that referenced this issue Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants