Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: dgw <[email protected]>
  • Loading branch information
Exirel and dgw authored Oct 23, 2019
1 parent 05c0c07 commit 9836efb
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions test/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,22 +42,22 @@
'#sopel',
'&peculiar',
'#private',
'"#startquote', # start quote withtout end quote: kept
'"#startquote', # start quote without end quote: kept
'&endquote"',
'"&quoted"', # quoted, but no #: quotes kept
]

if sys.version_info.major < 3:
# Python 2.7's ConfigParser interpret as comments
# Python 2.7's ConfigParser interprets as comment
# a line that starts with # or ;.
# Python 3 on the other hand, allow comments to be indented.
# Python 3, on the other hand, allows comments to be indented.
# As a result, the same config file will result in a different
# config file depending on the Python version used.
# config object depending on the Python version used.
# TODO: Deprecated with Python 2.7.
TEST_CHANNELS = [
'#sopel',
'&peculiar',
'# python 3 only comment', # indented line are not comment for Py2
'# python 3 only comment', # indented lines cannot be comments in Py2
'#private',
'"#startquote',
'&endquote"',
Expand Down Expand Up @@ -339,7 +339,7 @@ def test_save_modified_config(multi_fakeconfig):
'#sopel',
'#private',
'&peculiar',
'"#startquote', # start quote withtout end quote: kept
'"#startquote', # start quote without end quote: kept
'&endquote"',
'"&quoted"', # doesn't start with a # so it isn't escaped
]

0 comments on commit 9836efb

Please sign in to comment.