-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize packaging #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Makefile
and added dev-tools is a bit more than just "Modernize packaging", but I know you mean well 🤪
@Exirel If you can get back to this soon-ish, that'd be helpful. Otherwise I will most likely implement my own subset of it—just the packaging and "if Sopel 8" parts, no extra tooling—for a version-bump compatible with Sopel 8.0. |
Yup, done! Edit: I'm waiting on your approval to squash these commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have I tested all the extra build/dev tools? No, lol. But I trust you to create a better dev environment than me, at this point.
About all I can say about this rework is that it's probably not necessary to keep the py2 stuff (e.g. encoding comment) around. sopel-slap 0.1 will work with Sopel 7.x indefinitely, and 0.2 could just be for 8+ only now that 8.0 has released.
While awaiting a squash, I have set up Trusted Publishing for this repository so I can easily cut a new release post-merge. 😺 |
Github is annoying, it didn't send me the approval email notification, so I didn't see it until now. Will see if I can manage that tonight. |
4e400a0
to
34c7725
Compare
Squashed and I removed 3.7 as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little backward-compatibility nit, sorry 😅
In preparation for Sopel 8 and with the ongoing effort to modernize packaging everywhere:
pyproject.toml
for modern packagingMakefile
to performmake develop build
("release" could be added, if asked)setup.cfg
setup.py
__init__.py
intoplugin.py
, as to prepare future change (with config and stuff)To release on pypi, use
python -m twine upload dist/*
after using themake build
command.You can now use
make develop
to automatically update your virtualenv and have an editable install.