png palette import fix #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to consolidate some commits that were left behind in BrawlBox, with changes that have been bade to BrawlCrate since it branched off.
|
What precisely does this fix? Crate already had fixes in place for the DPI and at least one bug with PNG palettes. I didn't merge in the code when it was pushed to Box initially due to some bugs I found when testing it (though it was long enough ago that these may have been fixed and I don't recall what they were) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to consolidate some commits that were left behind in BrawlBox, with changes that have been made to BrawlCrate since it branched off. These changes are based off of libertyernie/png-palette-import-fix, which was branched and merged with the BrawlBox's master branch after BrawlCrate.
The Brawlbox commits read
If PngBitmapDecoder can't load a PNG, give up on importing palette and fall back to loading at a higher level.Adjust for DPI when importing indexed PNG.Merge pull request #232 from libertyernie/png-palette-import-fixPNG import fixes