Skip to content

Commit

Permalink
refactor(compiler): Delete TemplateDefinitionBuilder acceptance tes…
Browse files Browse the repository at this point in the history
…t expectations (angular#54757)

Many acceptance tests define goldens for both `TemplateDefinitionBuilder` and Template Pipeline. All such tests have had the TDB golden files removed, and the corresponding expectations adjusted.

PR Close angular#54757
  • Loading branch information
dylhunn authored and alxhub committed Mar 9, 2024
1 parent ef32b53 commit 54340a9
Show file tree
Hide file tree
Showing 71 changed files with 117 additions and 1,580 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@
"files": [
{
"generated": "local_reference_nested.js",
"expected": "local_reference_nested_template.js",
"templatePipelineExpected": "local_reference_nested.pipeline.js"
"expected": "local_reference_nested.pipeline.js"
}
]
}
Expand All @@ -43,8 +42,7 @@
"failureMessage": "Incorrect template",
"files": [
{
"expected": "local_reference_and_context_variables_template.js",
"templatePipelineExpected": "local_reference_and_context_variables_template.pipeline.js",
"expected": "local_reference_and_context_variables_template.pipeline.js",
"generated": "local_reference_and_context_variables.js"
}
]
Expand Down

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@
"failureMessage": "Invalid MyApp definition",
"files": [
{
"expected": "pipes_my_app_def.js",
"templatePipelineExpected": "pipes_my_app_def.pipeline.js",
"expected": "pipes_my_app_def.pipeline.js",
"generated": "pipes.js"
}
]
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@
{
"files": [
{
"expected": "safe_access_temporaries_template.js",
"templatePipelineExpected": "safe_access_temporaries_template.pipeline.js",
"expected": "safe_access_temporaries_template.pipeline.js",
"generated": "safe_access_temporaries.js"
}
],
Expand Down Expand Up @@ -78,8 +77,7 @@
{
"files": [
{
"expected": "safe_call_template.js",
"templatePipelineExpected": "safe_call_template.pipeline.js",
"expected": "safe_call_template.pipeline.js",
"generated": "safe_call.js"
}
],
Expand All @@ -96,8 +94,7 @@
{
"files": [
{
"expected": "safe_access_non_null_template.js",
"templatePipelineExpected": "safe_access_non_null_template.pipeline.js",
"expected": "safe_access_non_null_template.pipeline.js",
"generated": "safe_access_non_null.js"
}
],
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,7 @@
"failureMessage": "Incorrect attribute array",
"files": [
{
"expected": "exclude_bindings_from_consts_template.js",
"templatePipelineExpected": "exclude_bindings_from_consts_template.pipeline.js",
"expected": "exclude_bindings_from_consts_template.pipeline.js",
"generated": "exclude_bindings_from_consts.js"
}
]
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -379,8 +379,7 @@
"files": [
{
"generated": "deceptive_attrs.js",
"expected": "deceptive_attrs.template.js",
"templatePipelineExpected": "deceptive_attrs.pipeline.js"
"expected": "deceptive_attrs.pipeline.js"
}
]
}
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@
"files": [
{
"generated": "local_ref_on_host.js",
"expected": "local_ref_on_host.template.js",
"templatePipelineExpected": "local_ref_on_host.pipeline.js"
"expected": "local_ref_on_host.pipeline.js"
}
]
}
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,8 @@
{
"files": [
{
"expected": "switch_with_pipe_template.js",
"generated": "switch_with_pipe.js",
"templatePipelineExpected": "switch_with_pipe_template.pipeline.js"
"expected": "switch_with_pipe_template.pipeline.js"
}
],
"failureMessage": "Incorrect template"
Expand Down Expand Up @@ -144,9 +143,8 @@
{
"files": [
{
"expected": "if_with_pipe_template.js",
"generated": "if_with_pipe.js",
"templatePipelineExpected": "if_with_pipe_template.pipeline.js"
"expected": "if_with_pipe_template.pipeline.js"
}
],
"failureMessage": "Incorrect template"
Expand Down Expand Up @@ -190,8 +188,7 @@
{
"files": [
{
"expected": "if_nested_alias_listeners_template.js",
"templatePipelineExpected": "if_nested_alias_listeners_template.pipeline.js",
"expected": "if_nested_alias_listeners_template.pipeline.js",
"generated": "if_nested_alias_listeners.js"
}
],
Expand Down Expand Up @@ -281,8 +278,7 @@
{
"files": [
{
"expected": "for_template_variables_template.js",
"templatePipelineExpected": "for_template_variables_template.pipeline.js",
"expected": "for_template_variables_template.pipeline.js",
"generated": "for_template_variables.js"
}
],
Expand All @@ -297,8 +293,7 @@
{
"files": [
{
"expected": "for_aliased_template_variables_template.js",
"templatePipelineExpected": "for_aliased_template_variables_template.pipeline.js",
"expected": "for_aliased_template_variables_template.pipeline.js",
"generated": "for_aliased_template_variables.js"
}
],
Expand Down Expand Up @@ -328,8 +323,7 @@
{
"files": [
{
"expected": "for_template_variables_listener_template.js",
"templatePipelineExpected": "for_template_variables_listener_template.pipeline.js",
"expected": "for_template_variables_listener_template.pipeline.js",
"generated": "for_template_variables_listener.js"
}
],
Expand Down Expand Up @@ -374,8 +368,7 @@
{
"files": [
{
"expected": "for_template_variables_scope_template.js",
"templatePipelineExpected": "for_template_variables_scope_template.pipeline.js",
"expected": "for_template_variables_scope_template.pipeline.js",
"generated": "for_template_variables_scope.js"
}
],
Expand Down

This file was deleted.

Loading

0 comments on commit 54340a9

Please sign in to comment.