Fix all the things #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
force-pushed
the
misc-improvements
branch
from
ae50cce to
0fc1990
Compare
marcphilipp
force-pushed
the
misc-improvements
branch
from
a09c0e7 to
f3339cb
Compare
marcphilipp
force-pushed
the
misc-improvements
branch
from
f3339cb to
4b38f4c
Compare
|
@marcphilipp I'm still getting one test failing. Maybe it's not a big deal? It's example004WriteFixedWidthUsingConversions for me locally and in the CI. |
|
@marcphilipp Oh, I see! It's the Timezone. I'm adding your Timezone fix to the WriterExamples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see individual commits for rationale