-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-Steam: SteamGridDB and getid/gettitle Commandline Support #963
Conversation
This PR adds many, many functions for interfacing with the The next step for this PR is to fetch the icon for Non-Steam Games. |
Oh yeah, we'll also need to run shellcheck and do some fixups. I haven't checked yet but I suspect it'll be a real mess... |
…getGridsForNonSteamGames
Untested implementation for setting the shortcut icon. There are now three mostly untested changes:
I also did a quick run of ShellCheck. No glaring errors, just a couple of style, globbing, and unused/unnecessary variable changes that need addressed. Once the above testing is done and this is all working, it should be straightforward to address those and get this merged. We're almost there! |
Can't set the icon in It is updating the |
We should also add some more logging before merging this PR. |
Got some rough changes locally that I'll push soon which resolve the remaining functionality issues, and allow icons to be downloaded and set when updating grids for Non-Steam Games! We correctly edit Some more testing needs to be done, and there is some potential to break out a couple of areas into separate functions, bbut functionally the PR is complete once I push my local changes. Major progress, really just testing and cleanup remains! |
Tested adding Non-Steam Games, setting the icon appears to still work. |
Shellcheck fiixes in place, this is probably ready for merging after a couple more tests... |
Add Non-Steam Game still works, getid/title still works, editing shortcut fields works, I think this is ready to merge! Testing and shellcheck are green and version is bumped. No langfile changes here. The way we handle which column to edit in I never did update the PR description but I think it's fine. |
Heavily WIP, currently does the following:
shortcuts.vdf
getIDFromTitle
getTitleFromID
steamtinkerlaunch update grid nonsteam
(alternatively,update grid shortcut
)Remaining work before I edit this PR description with something more informative and structured: