Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commandline: Allow set command to take 'global' instead of AppID #840

Merged
merged 3 commits into from
Jun 24, 2023

Conversation

sonic2kk
Copy link
Owner

@sonic2kk sonic2kk commented Jun 18, 2023

This allows for setting a value in the Global config.

TODO:

  • Test for any breakages
  • Test command output
  • Update helpscreen

This allows for setting a value in the Global config.
@sonic2kk
Copy link
Owner Author

Low on time currently so this may have to wait a bit. Anyone interested is free to test as well though. I tested a little bit after I made this PR and it worked ok

@sonic2kk
Copy link
Owner Author

Command output works fine, it outputs the correct variables when incorrect usage is performed.

The help screen should also be updated for this.

@sonic2kk
Copy link
Owner Author

As for breakages, this appears to be strictly a user-facing option. I also used this branch for a while without realising it and it worked fine, so this is probably good to merge.

@sonic2kk sonic2kk merged commit 4737bb9 into master Jun 24, 2023
@sonic2kk sonic2kk deleted the set-cmd-global-cfg branch June 24, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant