Vortex: Remove LC_ALL from start command #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #779.
Vortex is currently launched with
LC_ALL="C", this previously fixed an issue with the Documents folder not being found (#41 (comment)). However it has since been reported in '779 that this causes issues with files which contain unicode characters, as the C locale does not support unicode characters.This removes the
LC_ALLvariable from the Vortex start command, which does resolve the issue. It does not yet appear that this causes issues with Vortex, so the Documents issue (reported almost 3 years ago at this point) may have since been resolved. Further testing is required, but the user in #779 has tested and reported no issues. Of course, further testing is welcome.Following v11.11 there were several changes made to how SteamTinkerLaunch handles setting locale to work around bugs i.e. on Steam Deck, so the issue may have been resolved with those changes as well.
I also removed
LC_ALL="C"from the Depressurizer start command. I have no idea if anyone still uses Depressurizer, no one has even mentioned it as far as I have seen and I have never touched that section of the code until now. But for consistency I have removed it, as it was the only other place in the code thatLC_ALL="C"was set before launching a program.If a user has an incorrectly configured locale on their system they may run into this issue still, the same way they would when trying to use SteamTinkerLaunch with games which contain special characters in their name (see the Troubleshooting wiki page).
Provided there are no issues with this change and that Vortex still functions as expected, I will merge this as it is a useful fix, assuming no regressions 😉