Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steam Deck: Remove wget dependency #758

Merged
merged 4 commits into from
Mar 8, 2023
Merged

Steam Deck: Remove wget dependency #758

merged 4 commits into from
Mar 8, 2023

Conversation

sonic2kk
Copy link
Owner

@sonic2kk sonic2kk commented Mar 6, 2023

Seems like wget is now installed on Steam Deck, at least with relatively modern versions of SteamOS (3.3.X and above), and so is not installed by STL since it comes with the system (the check if the command exists before fetching already passed because it's part of SteamOS base).

Need to test this to ensure it works, hence the PR and not a direct push for such a minor change.

@sonic2kk
Copy link
Owner Author

sonic2kk commented Mar 8, 2023

Tested on my Steam Deck with a completely fresh install of STL using this branch installed via ProtonUp-Qt, had no issues. I also confirmed that the same version of wget requested by SteamTinkerLaunch is available on SteamOS.

Just needs a version bump and a slim to ensure I removed all wget references and this is ready to merge.

@sonic2kk
Copy link
Owner Author

sonic2kk commented Mar 8, 2023

SDREPO seems unused, according to shellcheck and verified with a Ctrl+F. Commented out for now in case it could be used in future for any other potential dependencies.

@sonic2kk sonic2kk merged commit 92e99b6 into master Mar 8, 2023
@sonic2kk sonic2kk deleted the wget-outta-here branch March 8, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant