-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not installing on steam deck #651
Comments
Can you reproduce the ProtonUp-Qt hanging running ProtonUp-Qt from source? You may need to manually install the PUPQT dependencies. There were a couple of reports of hanging on install but I couldn't reproduce from source, so I think it may have been a Flatpak thing that has since been resolved in main. Edit: Just seen the script itself is failing for you. I'll investigate now... |
Ooooh, the recent change in 6072483 seem to be causing the issue. However it has a check for Steam Deck, I guess it's being called too early... |
Just pushed a commit which should hopefully resolve it. Config entry paths should get updated automatically too :-) Not sure how I didn't catch this in my tests on Deck, but I did keep in mind for the last few days that this change could cause some issues. Thanks for reporting! |
still seems to not call the steam deck function correctly...
|
Hmm, seems like it's unhappy about the language files for some reason. Could you try deleting/renaming your |
Just thinking out loud but the local install check may need to go right after steamdedeckt... |
that was with a clean im thinking this may be faling as this produces nothing (is it supposed to?)
here is a cat
just taking some stabs in the dark here lol EDIT: NVM looks like it's not even going into the |
by moving the call to steamdedeck to above load language I was able to get it to load though it looks like its complaining about something?
the HELLO and debug lines where echo lines I added for debugging :) |
Thanks for testing some more! I pushed a change that may resolve the complains. You may need to run The error about integer expression is because The error "No summary specified" is from |
Ah! I just seen your other comment, sorry (tired after work today...)
The |
Ah! Now I remember why i had the local install check where I did - I put it there so the paths would be set before the language file was loaded. But it should probably work fine now that I think about it, I think loadLangFile has some checks for where and how to load the language files... |
wouldn't removing i did that and I still get the same thing as above
maybe i also need the lang files downloaded? but i don't remember that being the case or it being in the wiki.... |
Ah! If you don't have it, you need a full SteamTinkerLaunch download. So either do a full SteamTinkerLaunch will "download" the language files in that it'll clone itself to |
ahh ok i was under the assumption that it would auto-download the lang files for you and you just needed the main file. my bad. Yes git cloning the whole thing does work going to try protonup now too |
Ahhh awesome! I guess a check could be added for the langfiles if they aren't in the same directory as the script, but at the moment that sounds like a lot to me. Maybe in future I'll take a look at implementing it, it wouldn't be an unwelcome feature. But it's not really what I would call "expected" usage - It likely worked because as I don't think there were many checks for langfiles. I added a lot more complexity to the SteamTinkerLaunch Steam Deck install process in #629 - A bit more probably wouldn't be the end of the world but right at this moment there are other things on my mind to add first. Sorry about that, but thank you for testing as I had no idea about this use-case and that this use-case could be problematic. I tried to cover a lot in my original Steam Deck improvements PR but I missed that 😓 Thanks for all the testing and for going ahead and trying ProtonUp-Qt again! I'm currently working on a PR to improve STL support with ProtonUp-Qt in-between adding HMM support to STL :-) |
no worries I re-read the wiki and yeah it does mention downloading the whole release I just remember (back when frostwork first added deck support) it is just downloading the script and it would auto-download everything proton up is still hanging on extracting stl(git) but that may be more of a bug for protonup than here? |
I will keep in mind about adding support for loading the language files after the install from source if they can't be found. Probably at least
Yeah that's been reported before and I think it's an issue with the Flatpak that hasn't been rolled out into a full release yet. You could try ProtonUp-Qt from source and see if you can install it that way. And though it's been reported before I think this confirms that the current implementation at least on Flatpak Steam Deck has some problem. But I think it's fixed in source, at least on my Steam Deck running from source it seems to work. |
Before closing, could you also check the |
this? Also yeah was able to get it installed fine with the latest prontonup-qt git |
Yup, perfect. Thank you! 😅
Okay, phew, so this is something that'll be resolved in the next release of ProtonUp-Qt. Awesome, thank you so much for your work testing this! Closing... |
commit 2018d45 Merge: 3137922 021f7e5 Author: zany130 <[email protected]> Date: Sun Nov 13 15:49:34 2022 -0500 Merge branch 'reshade_version_override' of https://github.com/zany130/steamtinkerlaunch into reshade_version_override commit 3137922 Author: zany130 <[email protected]> Date: Sun Nov 13 15:49:17 2022 -0500 fix autoBumpReShade commit 021f7e5 Merge: 6424c69 90c95b7 Author: Eamonn Rea <[email protected]> Date: Sat Nov 12 20:26:26 2022 +0000 Merge branch 'master' into reshade_version_override commit 90c95b7 Author: Eamonn Rea <[email protected]> Date: Sat Nov 12 03:25:27 2022 +0000 Remove useless Flatpak warning Does not work as Flatpak STL does not come with sh, and since users on Steam Deck (at least the ones that complain it doesn't work) almost certainly wont have Flatpak Steam installed, they won't be able to run the script at all and so it won't show up. commit b731f7e Author: Eamonn Rea <[email protected]> Date: Sat Nov 12 03:03:28 2022 +0000 Add check for JQ installation before generating online Proton versions JQ is required for online Proton version checking. In future we could potentially remove the reliance on this and instead parse it with a different function commit e89df4e Author: Eamonn Rea <[email protected]> Date: Sat Nov 12 01:06:02 2022 +0000 HMM: Only install Winetricks for installed games commit 064b947 Author: Eamonn Rea <[email protected]> Date: Sat Nov 12 00:24:07 2022 +0000 version bump commit e69f02a Author: Eamonn Rea <[email protected]> Date: Sat Nov 12 00:23:55 2022 +0000 HMM: Fix wrong RUNWINE name Stopped Sonic Generations from correctly applying Winetricks commit 27c3c6e Author: Eamonn Rea <[email protected]> Date: Fri Nov 11 22:14:40 2022 +0000 Add HedgeModManager usage to help screen commit ce9b196 Author: Eamonn Rea <[email protected]> Date: Fri Nov 11 21:52:22 2022 +0000 Add HedgeModManager support commit 6424c69 Author: zany130 <[email protected]> Date: Thu Nov 10 18:45:33 2022 -0500 some sanity checks and more autoBumpReShade work commit ea566c8 Author: zany130 <[email protected]> Date: Thu Nov 10 16:05:30 2022 -0500 update lang files commit 8f9443e Author: zany130 <[email protected]> Date: Thu Nov 10 15:42:58 2022 -0500 fix reshade override list and some skel work on Auto bumping global reshade version commit b6c24d6 Author: zany130 <[email protected]> Date: Thu Nov 10 13:45:24 2022 -0500 autopopulating reshade list and some cleanups commit 39ad6e8 Author: zany130 <[email protected]> Date: Wed Nov 9 22:38:01 2022 -0500 minor fix indentation commit 8dda5a9 Author: zany130 <[email protected]> Date: Wed Nov 9 22:23:37 2022 -0500 skel reshade vulkan support and update overrideReshadeVersion as @sonic2kk suggested :) commit 0210acf Author: zany130 <[email protected]> Date: Wed Nov 9 21:45:35 2022 -0500 Add override toggle commit a3a557e Author: zany130 <[email protected]> Date: Wed Nov 9 20:22:53 2022 -0500 Fixes and cleanups Fixed the overriding issue by setting the first value of RESHADEVERSIONS to RSVERSOVRD and removing the RSVERS in the command to make the dropdown commit 6b329ee Author: zany130 <[email protected]> Date: Wed Nov 9 19:04:47 2022 -0500 minor commit 555cdeb Author: Eamonn Rea <[email protected]> Date: Wed Nov 9 22:01:49 2022 +0000 Always update Yad config entry on Steam Deck If SteamTinkerLaunch is installed, but the config folder goes missing, the Yad binary may not get set again since we don't call setYadBin again on Steam Deck. Force add the path to the Yad bin to the global config if Yad is found on Steam Deck. Should address sonic2kk#646 commit 891315b Author: Eamonn Rea <[email protected]> Date: Wed Nov 9 18:31:48 2022 +0000 More work for sonic2kk#651 commit 95ad206 Author: Eamonn Rea <[email protected]> Date: Wed Nov 9 17:40:47 2022 +0000 Fix local install check on Steam Deck commit dae5c47 Author: zany130 <[email protected]> Date: Tue Nov 8 20:00:21 2022 -0500 some fixes for hardcoded reshade versions commit a279216 Author: zany130 <[email protected]> Date: Tue Nov 8 16:48:03 2022 -0500 fix missing hardcoded reshade versions commit 43bb296 Author: zany130 <[email protected]> Date: Tue Nov 8 16:33:58 2022 -0500 fix installRSdll commit da57b7b Merge: eeabc5a 907a03b Author: Andres <[email protected]> Date: Tue Nov 8 15:19:45 2022 -0500 Merge branch 'sonic2kk:master' into reshade_version_override commit eeabc5a Author: zany130 <[email protected]> Date: Tue Nov 8 15:17:07 2022 -0500 add reshade version override
System Information
Issue Description
On protonupqt it is not installing it just hangs and manually downloading and running the script gives this
Shouldn't it auto-download the langs and everything else into
/home/deck/stl/
?Logs
seems like the steam deck function is not running?
The text was updated successfully, but these errors were encountered: