added tests for Lang::Sound methods: rest?, truthy?, should_trigger? #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaaron
added a commit
that referenced
this pull request
Mar 14, 2016
added tests for Lang::Sound methods: rest?, truthy?, should_trigger?
|
Brilliant thanks - please feel very free to add any other tests you find interesting to write :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I browsed through the project and it occurred to me that the system is not fully tested currently. This was confirmed by a coverage tool. I have written some tests to cover a few simple methods from the SonicPi::Lang::Sound module.
Hope it helps a little!