[macsec_sonic] driver support for macsec_include_sci #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pterosaur Please review new attribute support in macsec_sonic driver. |
Pterosaur
approved these changes
Jul 26, 2021
5 tasks
Pterosaur
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Oct 25, 2021
Signed-off-by: Ze Gan <[email protected]> 986a835153b3df3a37492fbd3a83fc8e38a40c10 Proactively rekey sonic-net/sonic-wpa-supplicant#36 b84dd21ac7b76686caf53f2e9a2c8eb80519ab31 Fix azurepieline download sonic swss common deb pakcage sonic-net/sonic-wpa-supplicant#37 66002de9d5e3165ccdbed40451db86ae0a8b3944 [macsec_sonic] driver support for macsec_include_sci sonic-net/sonic-wpa-supplicant#35 dae8f59cb54c90bc9011bd675806a75dd0808d27 MACsec XPN changes sonic-net/sonic-wpa-supplicant#34 c2271b2879ed157718edb51e842a3e33debeab7f Move SSCI from SC to SA and change packet number field name to adapt sai 1.7.1 sonic-net/sonic-wpa-supplicant#26 1bbc8f1ef463dd21428ce80b72da107f3bd2f3f0 Fix for CP state machine issues sonic-net/sonic-wpa-supplicant#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Support was previously added for "macsec_include_sci" attribute in wpasupplicant configuration profile, but this support was not extended to macsec_sonic driver and SONiC APPL_DB. I have added the needed support in the macsec_sonic driver to allow the "send_sci" APPL_DB attribute to be configured by "macsec_include_sci" wpasupplicant attribute.
Why I did it
Missing support in wpasupplicant macsec_sonic driver for send_sci APPL_DB attribute.
How I verified it
System test with VS and JNPR platforms.
Details if related
N/A