Fix missing refactor #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
can you have better description of the issue of this pr? |
|
also rebase you changes. |
Pterosaur
force-pushed
the
fix_missing_refactor
branch
2 times, most recently
from
196269c
to
1fabaed
Compare
Signed-off-by: Ze Gan <[email protected]>
Pterosaur
force-pushed
the
fix_missing_refactor
branch
from
1fabaed
to
066b0f7
Compare
Please check it again. |
lguohan
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's clearer to rename the init_pn to next_pn.
We have a commit(e77db61) to rename all init_pn to next_pn. But it forgot to modify the name in
macsec_sonic_set_transmit_next_pn. This PR is for fixing this mistake.